fix: Don't AutoScroll to embed when multiple-duration event's booking page is embedded #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update version * fix button to match new spec * migrate tests to objectContaining * fix tests * update RTL * yarn.lock update * bump fetch mock to latest vitest version * update deep mock to use vitest 2.0 * fix mock prisma type cast * meet base test fn singature for V2 * remove console.log from next test
Co-authored-by: Replexica <[email protected]>
* chore: EventTypeWebWrapper base pr * fixup! chore: EventTypeWebWrapper base pr * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * wip * fix: error * Event type atom wrapper handles app dir * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * remove console log * review comments * fixup! review comments * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base --------- Co-authored-by: Somay Chauhan <[email protected]>
* refactor: define inputs and outputs by separating default and custom fields * refactor: event type api <-> internal transformers * refactor: v2 use refactored libraries to transform input and output booking fields * refactor: dont allow custom slugs with default reserved slugs * refactor: input service store only specific default system fields * refactor: atoms display only specific default system fields * refactor: delete unused system field constants * fix: tests * fix: old event types * fix: imports * fix: import * chore: release libraries and use v2 with them * fix: unit tests * refactor: push email in case of missing phone * refactor: satisfies check for event-type locations
* fix: fixed more flaky e2e tests (round 2) * update * fix and update * update
* added retell ai to app store * added retell ai
* chore: EventTypeWebWrapper base pr * fixup! chore: EventTypeWebWrapper base pr * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * wip * fix: error * Event type atom wrapper handles app dir * fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * fixup! fixup! Merge branch 'main' into morgan/cal-4183-eventtypeatom-web-wrapper-base * remove console log * refactor: event-type-atom (setup tab) * review comments * update: better naming * fixup! review comments * revert: defaultMenuIsOpen --will create a separate PR --------- Co-authored-by: Morgan Vernay <[email protected]> Co-authored-by: Morgan <[email protected]>
…erSideProps`/`getStaticProps` to `/lib` (calcom#16458) * booking: Move getServerSideProps to /lib * remove duplicate * bookings: Move getStaticProps to /lib * fix type check * replace setHeader with a server action call in withEmbedSSR * Add env variables for booking
* chore: removes unnecessary prisma env warnings * Revert lockfile Signed-off-by: zomars <[email protected]> * Update yarn lock Signed-off-by: zomars <[email protected]> --------- Signed-off-by: zomars <[email protected]>
* docs: schedules * docs: wip event-types * docs:event-types * docs:event-types * Delete yarn.lock * Revert "Delete yarn.lock" This reverts commit bb3eb23. --------- Co-authored-by: Morgan <[email protected]>
calcom#16648) * fix settings/admin/page * remove references to pages for settings/teams * remove double layouts * move pages that do not need layout out of (settings) group * fix * fix * fix * fix * add sso page and fix layouts
github-actions
bot
added
High priority
⚡ Quick Wins
embed
❗️ migrations
❗️ .env changes
and removed
High priority
⚡ Quick Wins
embed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes calcom#10590
The issue occurs only for an event with multiple durations enabled
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?