Added two more corner rounding types (top corners only & bottom corners only), and ability to pass custom animation duration. #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following new features & bug fixes
GTProgressBarCornerType
which areGTProgressBarCornerType.topCornersOnly and GTProgressBarCornerType.bottomCornersOnly
These will have the following effects.
Bug Fixes
Additionally I have also edited the corner radius section original
view.frame.height / 2 * 0.7
changed to --->view.frame.height / 2
, The reason is because the corner radius was not a smooth curve as expected when you halve the height or width.Was there a reasoning behind to why 0.7 was multiplied that I missed? If not then I think getting rid of that 0.7 fixes a bug.
PS: - I am currently using this fork on our app with no issues, if there is something off please let me know.