Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default python executable should be python3 #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wlach
Copy link

@wlach wlach commented May 24, 2020

On Mac (still) the default python is python2, but it's python3 that you almost
certainly want. Make this the default.

On Mac (still) the default python is python2, but it's python3 that you almost
certainly want. Make this the default.
@bremner
Copy link

bremner commented Aug 3, 2020

This would be desirable on Debian and derivatives (e.g. Ubunto as well). The change for windows looks a bit suspect, but I don't know, I'm not a Windows user.

@greghendershott
Copy link
Owner

Preface: I no longer use Frog myself. It's in low-maintenance mode. I have limited time to delve into this, including testing with various permutations of operating systems and Python versions.

example/frog.rkt is just that -- an example. Some users won't use Pygments at all. Those who do install and use it, will know more about the version of Pygments they installed and what version(s) of Python it needs.

So I'm not sure there's any one correct default here, and again this is just an example configuration?

@bremner
Copy link

bremner commented Aug 5, 2020 via email

@wlach
Copy link
Author

wlach commented Aug 5, 2020

Preface: I no longer use Frog myself. It's in low-maintenance mode. I have limited time to delve into this, including testing with various permutations of operating systems and Python versions.

example/frog.rkt is just that -- an example. Some users won't use Pygments at all. Those who do install and use it, will know more about the version of Pygments they installed and what version(s) of Python it needs.

So I'm not sure there's any one correct default here, and again this is just an example configuration?

FWIW this was a bit of a gotcha and it took me some time to figure out what was going on, which is what motivated me to file the PR. It's possible that landing this would just cause another set of issues. I too don't really have time or inclination to explore this further, maybe the best thing (if it's ok with the maintainer) is just to leave this open for now as a warning to others. At some point in the hopefully-not-too-distant-future, python2 will become rare.

Copy link

@lojic lojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend this change. Having python instead of python3 caused me some trouble initially on Mac OS. I'm not familiar with the situation on Windows, so if that's questionable, the pull request could be modified to only change non-Windows.

@dertuxmalwieder
Copy link

On Windows, it would be “py -3”, preferably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants