Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial add of dhimmel to authors #955

Merged
merged 5 commits into from
Apr 30, 2021
Merged

Conversation

rando2
Copy link
Collaborator

@rando2 rando2 commented Apr 30, 2021

@mprobson do you need conflict of interest info for ACM? I'm waiting to hear back on that but this should be most of the required metadata for submitting I think!

Description of the proposed additions or changes

Related issues

Suggested reviewers (optional)

Checklist

  • Text is formatted so that each sentence is on its own line.
  • Pre-prints cited in this pull request have a GitHub issue opened so that they can be reviewed.

@rando2
Copy link
Collaborator Author

rando2 commented Apr 30, 2021

Manubot is failing because of missing COI info!

@rando2 rando2 added Additional Reviews Welcome This paper has been summarized by 2 contributors, but more critques are always helpful! Methods Strategies for review and removed Additional Reviews Welcome This paper has been summarized by 2 contributors, but more critques are always helpful! labels Apr 30, 2021
@mprobson
Copy link
Collaborator

do you need conflict of interest info for ACM?

The best I could find was discussed here: #943 (comment). Basically significant CoI should be disclosed in an unnumbered footnote on the first page. @agitter is working on automatically generating a string that is pased as metadata to the template and inserted.

@AppVeyorBot
Copy link

AppVeyor build 1.0.4077 for commit 63b037d is now complete.

Found 16 potential spelling error(s). Preview:content/09.evolution.md:83:nonsynonymous
content/09.evolution.md:139:LVNA
content/23.vaccines-app.md:15:IgGs
content/23.vaccines-app.md:387:IgGs
content/60.methods.md:8:CCS
content/60.methods.md:65:ECRs
content/60.methods.md:81:Manubot's
content/60.methods.md:111:scite
content/60.methods.md:111:Scite
content/60.methods.md:147:scite
content/60.methods.md:164:ECR
content/60.methods.md:165:ECRs
content/60.methods.md:169:docx...
The rendered manuscript from this build is temporarily available for download at:

@agitter
Copy link
Collaborator

agitter commented Apr 30, 2021

We'll need to add the structured ACM affiliation metadata for Daniel as well (following the format in #943).

We can also remove Vince and Daniel from the general acknowledgements once they are both added as authors on the merged manuscript.

@rando2 rando2 merged commit f2ec4ba into greenelab:master Apr 30, 2021
@rando2 rando2 deleted the add_dhimmel branch April 30, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Methods Strategies for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants