Fix loading of NVD API results when there are none #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
mbrinkhoff
approved these changes
Aug 13, 2024
y0urself
approved these changes
Sep 3, 2024
n-thumann
force-pushed
the
fix_nvd_api_empty_results
branch
from
5f038c5 to
4cc4d17
Compare
|
@y0urself Looks like https://github.com/greenbone/pontos/actions/runs/10680616330/workflow failed to enable auto-merge 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the loading of NVD API results when there are none.
Why
E.g. https://services.nvd.nist.gov/rest/json/cves/2.0?lastModStartDate=2024-08-13T11%3A29%3A45%2B00%3A00&lastModEndDate=2024-08-13T11%3A30%3A15%2B00%3A00&startIndex=0&resultsPerPage=2000 returns an empty list of results.
This caused
self._current_request_resultsto be0(because there are0total results available), soraise NoMoreResults()will be never called. This results in the same request being made over and over again indefinitely.I added a test case to demonstrate the expected behavior.
References
Checklist