Skip to content

Commit

Permalink
Add faces for neotree
Browse files Browse the repository at this point in the history
  • Loading branch information
@kaofelix
kaofelix committed Mar 29, 2019
1 parent fb4bb8e commit bacc441
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ This theme contains custom support for the following features and plugins:
- Magit
- Markdown
- Message
- [Neotree](https://github.com/jaypei/emacs-neotree)
- Org
- Popup
- [RainbowDelimiters](http://www.emacswiki.org/emacs/RainbowDelimiters)
Expand Down
8 changes: 8 additions & 0 deletions gruvbox.el
View file
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,14 @@ Should contain 2 %s constructs to allow for theme name and directory/prefix")
(diredp-read-priv (:foreground gruvbox-bright_red :background gruvbox-dark_red))
(diredp-write-priv (:foreground gruvbox-bright_aqua :background gruvbox-dark_aqua))

;; neotree
(neo-banner-face (:foreground gruvbox-bright_purple :bold t))
(neo-dir-link-face (:foreground gruvbox-bright_yellow))
(neo-expand-btn-face (:foreground gruvbox-bright_orange))
(neo-file-link-face (:foreground gruvbox-light0))
(neo-header-face (:foreground gruvbox-bright_purple))
(neo-root-dir-face (:inherit neo-banner-face))

;; eshell
(eshell-prompt-face (:foreground gruvbox-bright_aqua))
(eshell-ls-archive-face (:foreground gruvbox-light3))
Expand Down

5 comments on commit bacc441

@aashiks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit produces the following error for me :

gruvbox-theme/:catch: Symbol’s value as variable is void: neo-banner-face

I don't have neotree installed. Maybe a check would solve the issue ?

@aashiks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked around it by using the following code that checks if neotree is installed:

 (when (featurep 'neotree)
 (neo-banner-face                           (:foreground gruvbox-bright_purple :bold t))
 (neo-dir-link-face                         (:foreground gruvbox-bright_yellow))
 (neo-expand-btn-face                       (:foreground gruvbox-bright_orange))
 (neo-file-link-face                        (:foreground gruvbox-light0))
 (neo-header-face                           (:foreground gruvbox-bright_purple))
 (neo-root-dir-face                         (:inherit neo-banner-face)))

@jasonm23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request would be accepted

@aashiks
Copy link

@aashiks aashiks commented on bacc441 Mar 30, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaofelix
Copy link
Contributor Author

@kaofelix kaofelix commented on bacc441 Mar 30, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.