Review #36
Open
Review #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments
Authentication Working With Bcrypt and oAuth2
Fix Minor Bugs
Fix Comment Ajax Call
| belongs_to :response | ||
|
|
||
| validates :user, uniqueness: { scope: :response, | ||
| message: "User can only vote on this response once."} |
|
Tests and seeding are failing - it looks like a migration to add a "caption" column to questions might be missing? Or have you edited an old migration then re-run the db:create db:migrate steps? Questions table has no caption column but both seeds and specs expect it to exist. |
| def destroy | ||
| @question.destroy | ||
|
|
||
| redirect_to questions_url, notice: 'Question was successfully destroyed.' |
There was a problem hiding this comment.
Handle failure here, even if you think it very unlikely. You are telling the user the question was destroyed. What if the delete failed for some reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.