Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Minor Edits to Available Expectation Types #9003

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

kwcanuck
Copy link
Contributor

In this Slack conversation, @joshzzheng requested minor changes to the topic Available Expectation types. These changes included removing links to the Expectations Gallery and the word type from the column heading. This PR implements these changes and minor changes to content added by a member of the DevRel team.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

@kwcanuck kwcanuck requested a review from a team as a code owner November 28, 2023 12:45
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 5f45c34
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6565e8d34b4e5f00082b82b7
😎 Deploy Preview https://deploy-preview-9003.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Nov 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwcanuck kwcanuck added this pull request to the merge queue Nov 28, 2023
Merged via the queue into develop with commit a909f08 Nov 28, 2023
57 checks passed
@kwcanuck kwcanuck deleted the expectation-types-update branch November 28, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants