[MAINTENANCE] Delete top-level utils #9000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
cdkini
commented
Nov 23, 2023
Comment on lines
725
to
729
| @measure_execution_time( | ||
| execution_time_holder_object_reference_name="data_assistant_result", | ||
| execution_time_property_name="profiler_execution_time", | ||
| pretty_print=False, | ||
| ) |
There was a problem hiding this comment.
If we need to profile performance, we can add temporary code to do so - I don't think we need to decorate each time.
If you disagree, lmk and I can bring this back
NathanFarmer
approved these changes
Nov 27, 2023
…_expectations into m/v1-35/remove_top_level_utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top level utils importable from
gx(likegx.read_csv()) should be deleted - we don't use these anymoreinvoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!