Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Delete extraneous validate_configuration definitions on Expectations #8999

Merged
merged 27 commits into from
Nov 27, 2023

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Nov 23, 2023

We don't need these method definitions if they simply call super() - let's clean up our code

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 7378bf1
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6564be840aaab000085dcddd

@cdkini cdkini self-assigned this Nov 23, 2023
@ghost
Copy link

ghost commented Nov 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cdkini cdkini enabled auto-merge November 27, 2023 16:10
@cdkini cdkini added this pull request to the merge queue Nov 27, 2023
Merged via the queue into develop with commit 2a3d0f7 Nov 27, 2023
65 checks passed
@cdkini cdkini deleted the m/v1-34/remove_validate_configuration_defs branch November 27, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants