Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] DSB-499: Add docs on securely managing credentials for api-created GX Cloud Data Sources #8992

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

rachhouse
Copy link
Contributor

Through investigation into a recent Cloud ticket, we surfaced that there is not currently explicit documentation on how to securely manage credentials for API-created Cloud Data Sources. I've added how-to instructions for users to use environmental variables when creating Cloud Data Sources and running the GX Agent.

https://greatexpectations.atlassian.net/browse/DSB-499

@kwcanuck , I've added this new content where I thought it made the most sense - feel free to edit and reorganize as you see fit. Let me know if you have any questions!

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@rachhouse rachhouse requested a review from a team as a code owner November 22, 2023 16:19
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 4c4bc0c
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6564e3e17b16e800074bb519
😎 Deploy Preview https://deploy-preview-8992.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Nov 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

@kwcanuck kwcanuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to implement or ignore the edits.

@rachhouse rachhouse added the devrel This item is being addressed by the Developer Relations Team label Nov 22, 2023
@rachhouse rachhouse self-assigned this Nov 22, 2023
@rachhouse rachhouse enabled auto-merge November 27, 2023 18:58
@rachhouse rachhouse added this pull request to the merge queue Nov 27, 2023
Merged via the queue into develop with commit a133348 Nov 27, 2023
55 checks passed
@rachhouse rachhouse deleted the DOCS/DSB-499/cloud-data-source-password-mgmt branch November 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants