Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Make mode arg to get_context take precedence #8990

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Nov 21, 2023

If I use mode, I should immediately jump into the helper function responsible for creating that context type - this will circument any issues where we accidentally get the wrong context type

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 9fbfee4
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65664dc2720df90008eb338e

@ghost
Copy link

ghost commented Nov 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cdkini cdkini marked this pull request as draft November 23, 2023 16:02
@cdkini cdkini marked this pull request as ready for review November 28, 2023 20:29
@cdkini cdkini self-assigned this Nov 28, 2023
@cdkini cdkini added this pull request to the merge queue Nov 29, 2023
Merged via the queue into develop with commit c24ca7a Nov 29, 2023
58 checks passed
@cdkini cdkini deleted the m/_/clean_up_get_context branch November 29, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants