Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Document GX Cloud Edit Expectation Suite Name Functionality #8988

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Nov 21, 2023

DOC-616 requests documentation for editing Expectation Suite names. This PR implements this request.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Appropriate tests and docs have been updated

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 30b5b2a
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/655cfabd2b68ca0009986fa7
😎 Deploy Preview https://deploy-preview-8988.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Nov 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kwcanuck kwcanuck requested a review from a team as a code owner November 21, 2023 18:45
Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might be nice if we could include the icon for the edit button -- eg, "Click on the Edit (icon) button for the Expectation Suite...." since it is a button rather than a labeled link and it doesn't look like the button has hover text or anything, but I that's a suggestion that you can take or leave. Possibly something to revisit through our Cloud docs once the Cloud UI has settled more and we know the icons for buttons aren't going to be changing.

@kwcanuck kwcanuck added this pull request to the merge queue Nov 21, 2023
Merged via the queue into develop with commit b9666da Nov 21, 2023
57 checks passed
@kwcanuck kwcanuck deleted the edit-expectation-suite-name branch November 21, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants