[MAINTENANCE] dry up validation status calc #8962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tyler-hoffman
changed the title
cdkini
reviewed
Nov 14, 2023
Comment on lines
+16
to
+22
| def calc_validation_statistics( | ||
| validation_results: list[ExpectationValidationResult], | ||
| ) -> ValidationStatistics: | ||
| """ | ||
| Calculate summary statistics for the validation results and | ||
| return ``ExpectationStatistics``. | ||
| """ |
There was a problem hiding this comment.
Do we envision this ever living on an object?
There was a problem hiding this comment.
IDK I thought about just making it a static method on ValidationStatistics. I don't really have strong opinions though. Seems like wrapping it in another class might be YAGNI though.
cdkini
approved these changes
Nov 14, 2023
Kilo59
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had 2 basically identical implementations of the same private method. This just moves it to a central location and removes the
_prefix. Note: this moves the stats to a new file to avoid a circular import that I suspect was the initial driver for the duplication.invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!