Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] remove deprecated usage of pydantic Extra #8896

Conversation

TrangPham
Copy link
Contributor

Pydantic is deprecating the use of Extra class and literal strings should be used in its place

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit f255234
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65401f0d7ac16f00085665d8

@github-actions github-actions bot added the core label Oct 30, 2023
@ghost
Copy link

ghost commented Oct 30, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@TrangPham TrangPham marked this pull request as ready for review October 31, 2023 00:53
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just for later reference, here is a link to the deprecation notice: https://github.com/pydantic/pydantic/blob/60c5db6e1ea55d4e5fc13234810d513b3b1b03ae/pydantic/deprecated/config.py#L66 (I didn't see it in the pydantic docs).

@TrangPham TrangPham added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@TrangPham TrangPham added this pull request to the merge queue Nov 1, 2023
Merged via the queue into develop with commit d3277ed Nov 1, 2023
80 checks passed
@TrangPham TrangPham deleted the ZEL-98-nice-to-have-oss-update-of-cdm-using-pydantic-v2-features branch November 1, 2023 22:35
Shinnnyshinshin added a commit that referenced this pull request Nov 1, 2023
* develop:
  [MAINTENANCE] remove deprecated usage of pydantic Extra (#8896)
  [MAINTENANCE] Better error msg for refrence environments (#8913)
  [FEATURE] Expect column specified percentile value to be above a given value. (#8907)
  [DOCS] add 'user' access token clarification to GX Cloud quickstart (#8912)
  [MAINTENANCE] Typing render/view  (#8903)
  [MAINTENANCE] Adjust timeouts for cloud-tests services (#8910)
  [DOCS] Update Section Title (#8905)
  [MAINTENANCE] List checkpoints endpoint contract test (#8886)
  [MAINTENANCE] Do not skip spark tests in cloud stage (#8901)
  [MAINTENANCE] Add Expectation Suite Pact tests (#8885)
  [MAINTENANCE] Get checkpoint endpoint contract test (#8881)
  [DOCS] Update Cloud Quickstart save expectation suite example (#8893)
  [RELEASE] 0.18.0 (#8895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants