Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] List checkpoints endpoint contract test #8886

Merged

Conversation

anthonyburdi
Copy link
Member

@anthonyburdi anthonyburdi commented Oct 27, 2023

Contract test for checkpoint list GET endpoint when at least one checkpoint exists.

(also contains changes from #8881, would be good to merge that first)

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@anthonyburdi anthonyburdi self-assigned this Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit cfe8fa6
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65413588f50b190008f7b27e
😎 Deploy Preview https://deploy-preview-8886.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Oct 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend


NON_EXISTENT_CHECKPOINT_ID: Final[str] = "6ed9a340-8469-4ee2-a300-ffbe5d09b49d"

EXISTING_CHECKPOINT_ID: Final[str] = "051a1f4d-6276-484a-81e5-3df4fadd5154"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you find this Checkpoint ID? I don't see it in the Mercury seed data.

@NathanFarmer NathanFarmer added this pull request to the merge queue Oct 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 31, 2023
@anthonyburdi anthonyburdi added this pull request to the merge queue Oct 31, 2023
Merged via the queue into develop with commit 9b59fc7 Oct 31, 2023
55 checks passed
@anthonyburdi anthonyburdi deleted the m/pp-661/pp-776/list-checkpoints-endpoint-contract-test branch October 31, 2023 19:59
Shinnnyshinshin added a commit that referenced this pull request Nov 1, 2023
* develop:
  [MAINTENANCE] remove deprecated usage of pydantic Extra (#8896)
  [MAINTENANCE] Better error msg for refrence environments (#8913)
  [FEATURE] Expect column specified percentile value to be above a given value. (#8907)
  [DOCS] add 'user' access token clarification to GX Cloud quickstart (#8912)
  [MAINTENANCE] Typing render/view  (#8903)
  [MAINTENANCE] Adjust timeouts for cloud-tests services (#8910)
  [DOCS] Update Section Title (#8905)
  [MAINTENANCE] List checkpoints endpoint contract test (#8886)
  [MAINTENANCE] Do not skip spark tests in cloud stage (#8901)
  [MAINTENANCE] Add Expectation Suite Pact tests (#8885)
  [MAINTENANCE] Get checkpoint endpoint contract test (#8881)
  [DOCS] Update Cloud Quickstart save expectation suite example (#8893)
  [RELEASE] 0.18.0 (#8895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants