-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] List checkpoints endpoint contract test #8886
Merged
anthonyburdi
merged 8 commits into
develop
from
m/pp-661/pp-776/list-checkpoints-endpoint-contract-test
Oct 31, 2023
Merged
[MAINTENANCE] List checkpoints endpoint contract test #8886
anthonyburdi
merged 8 commits into
develop
from
m/pp-661/pp-776/list-checkpoints-endpoint-contract-test
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
|
||
NON_EXISTENT_CHECKPOINT_ID: Final[str] = "6ed9a340-8469-4ee2-a300-ffbe5d09b49d" | ||
|
||
EXISTING_CHECKPOINT_ID: Final[str] = "051a1f4d-6276-484a-81e5-3df4fadd5154" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you find this Checkpoint ID? I don't see it in the Mercury seed data.
NathanFarmer
approved these changes
Oct 31, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 31, 2023
anthonyburdi
deleted the
m/pp-661/pp-776/list-checkpoints-endpoint-contract-test
branch
October 31, 2023 19:59
Shinnnyshinshin
added a commit
that referenced
this pull request
Nov 1, 2023
* develop: [MAINTENANCE] remove deprecated usage of pydantic Extra (#8896) [MAINTENANCE] Better error msg for refrence environments (#8913) [FEATURE] Expect column specified percentile value to be above a given value. (#8907) [DOCS] add 'user' access token clarification to GX Cloud quickstart (#8912) [MAINTENANCE] Typing render/view (#8903) [MAINTENANCE] Adjust timeouts for cloud-tests services (#8910) [DOCS] Update Section Title (#8905) [MAINTENANCE] List checkpoints endpoint contract test (#8886) [MAINTENANCE] Do not skip spark tests in cloud stage (#8901) [MAINTENANCE] Add Expectation Suite Pact tests (#8885) [MAINTENANCE] Get checkpoint endpoint contract test (#8881) [DOCS] Update Cloud Quickstart save expectation suite example (#8893) [RELEASE] 0.18.0 (#8895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract test for checkpoint list GET endpoint when at least one checkpoint exists.
(also contains changes from #8881, would be good to merge that first)
invoke lint
(usesblack
+ruff
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!