[MAINTENANCE] create Checkpoint endpoint contract test #8882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
…tions into PP-779-api-context-add-checkpoint-contract-test
josectobar
force-pushed
the
PP-779-api-context-add-checkpoint-contract-test
branch
from
5f06e52 to
22d293b
Compare
josectobar
changed the title
josectobar
force-pushed
the
PP-779-api-context-add-checkpoint-contract-test
branch
from
970ea3b to
9a98a4a
Compare
| "contract_interaction", | ||
| [ | ||
| ContractInteraction( | ||
| method="POST", |
There was a problem hiding this comment.
Are you testing the PUT or the POST? This request_path makes sense with the POST, but the request_body references PUT. Maybe you tried both.
| ), | ||
| request_body=PUT_CHECKPOINTS_MIN_REQUEST_BODY, | ||
| upon_receiving="a request to create a Checkpoint", | ||
| given="the Checkpoint is created", |
There was a problem hiding this comment.
I think the given state here is supposed to be "the Checkpoint does not exist".
|
These tests are no longer being added. Hopefully we can add more contract tests with the V1 API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add contract test for creating a Checkpoint in Cloud REST endpoint
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!