Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix logic for docker registry login invoke task #8878

Closed
wants to merge 9 commits into from

Conversation

nicgrayson
Copy link
Contributor

@nicgrayson nicgrayson commented Oct 27, 2023

CI env var is not set outside of CI

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 4d809e2
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/653ff4e1a2728900083684d3

@github-actions github-actions bot added the core label Oct 27, 2023
@nicgrayson nicgrayson changed the title Fix logic for docker registry login invoke task [BUGFIX] Fix logic for docker registry login invoke task Oct 27, 2023
@ghost
Copy link

ghost commented Oct 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

tasks.py Outdated Show resolved Hide resolved
@nicgrayson nicgrayson enabled auto-merge October 27, 2023 19:20
tasks.py Outdated Show resolved Hide resolved
@nicgrayson nicgrayson disabled auto-merge October 27, 2023 19:24
@nicgrayson nicgrayson closed this Oct 30, 2023
@nicgrayson nicgrayson deleted the b/fix-ect-login-logic branch October 30, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants