Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove docs-snippets name #8867

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

Kilo59
Copy link
Contributor

@Kilo59 Kilo59 commented Oct 25, 2023

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 21e04e0
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65393ffcabbd090008054f40

@Kilo59 Kilo59 changed the title remove name [MAINTENANCE] Remove docs-snippets name Oct 25, 2023
@github-actions github-actions bot added the core label Oct 25, 2023
@ghost
Copy link

ghost commented Oct 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@@ -92,7 +92,6 @@ jobs:
- 'tests/test_sets/**'

docs-snippets:
name: docs-snippets
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this as variable for why our branch protection rules aren't working

@Kilo59 Kilo59 enabled auto-merge October 25, 2023 14:46
@Kilo59 Kilo59 added this pull request to the merge queue Oct 25, 2023
Merged via the queue into develop with commit db53e5a Oct 25, 2023
52 checks passed
@Kilo59 Kilo59 deleted the m/_/docs-snippets-fix branch October 25, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants