[MAINTENANCE] Column Descriptive Metrics: Remove compute_metrics_with_aborted_metrics #8865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
| Tuple with two elements. The first is a dictionary with requested metrics resolved, with unique metric | ||
| ID as key and computed metric as value. The second is a dictionary with information about any metrics | ||
| that were aborted during computation, using the unique metric ID as key. | ||
| Tuple of two elements, the first is a dictionary with requested metrics resolved, |
Shinnnyshinshin
approved these changes
Oct 24, 2023
Shinnnyshinshin
approved these changes
Oct 24, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
…with-aborted-metrics
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
anthonyburdi
deleted the
m/zel-95/zel-99/refactor-compute-metrics-with-aborted-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were dropping the aborted metrics when returning the computed metrics in
compute_metrics()in the validator. In this PR we are returning the aborted metrics as well so that the callers can choose to drop it.The motivation of this PR was a refactor. For expediency, we introduced
compute_metrics_with_aborted_metrics()to use with Column Descriptive Metrics until we had a chance to change all the callers ofcompute_metrics()to not fail with the new return value.invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!