Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Column Descriptive Metrics: Convert table name to lowercase for snowflake #8817

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[BUGFIX] Column Descriptive Metrics: Convert table name to lowercase for snowflake #8817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions great_expectations/expectations/metrics/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,12 @@ def get_sqlalchemy_column_metadata(
# We must explicitly create a subquery
columns = table_selectable.columns().subquery().columns
else:
# TODO: remove cast to a string once [this](https://github.com/snowflakedb/snowflake-sqlalchemy/issues/157) issue is resovled
table_name = str(table_selectable)
if execution_engine.dialect_name == GXSqlDialect.SNOWFLAKE:
table_name = table_name.lower()
columns = inspector.get_columns(
str(
table_selectable
), # TODO: remove cast to a string once [this](https://github.com/snowflakedb/snowflake-sqlalchemy/issues/157) issue is resovled
table_name=table_name,
schema=schema_name,
)
except (
Expand Down
Loading