[BUGFIX] Fix Snowflake column identifier issue when running checkpoint #8630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temp tables false
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Kilo59
force-pushed
the
b/lakitu-312/sf-col-idtn
branch
from
9c81a2b to
5d72e3f
Compare
Kilo59
force-pushed
the
b/lakitu-312/sf-col-idtn
branch
from
687bf43 to
6438f7d
Compare
Kilo59
force-pushed
the
b/lakitu-312/sf-col-idtn
branch
from
6f8d070 to
1bacbad
Compare
Kilo59
commented
Sep 12, 2023
| if connection.dialect.name == "snowflake": | ||
| logger.warning("snowflake connection") # TODO: remove me | ||
| # connection.dialect.normalize_name = default_normalize_name | ||
| connection.dialect.normalize_name = ibis_normalize_name |
There was a problem hiding this comment.
@billdirks here is where the monkeypatching is done.
Kilo59
force-pushed
the
b/lakitu-312/sf-col-idtn
branch
from
476aa36 to
4963dd0
Compare
Kilo59
force-pushed
the
b/lakitu-312/sf-col-idtn
branch
from
52e29ff to
4caa61f
Compare
Kilo59
force-pushed
the
b/lakitu-312/sf-col-idtn
branch
from
e260fef to
5f75854
Compare
3 tasks
Will move the work to add the QUOTED_IDENTIFIERS_IGNORE_CASE field to a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative Solutions
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!