Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement suite factory add_or_update #10796

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

joshua-stauffer
Copy link
Member

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 40987e6
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6764889a917d7400086c480b
😎 Deploy Preview https://deploy-preview-10796.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (ab0a7f7) to head (40987e6).
Report is 5 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10796      +/-   ##
===========================================
- Coverage    80.70%   80.68%   -0.02%     
===========================================
  Files          465      465              
  Lines        40433    40449      +16     
===========================================
+ Hits         32631    32638       +7     
- Misses        7802     7811       +9     
Flag Coverage Δ
3.10 69.99% <100.00%> (-0.01%) ⬇️
3.10 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 filesystem ?
3.10 mysql ?
3.10 spark_connect ?
3.11 69.99% <100.00%> (-0.01%) ⬇️
3.11 athena or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 big ?
3.11 filesystem ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.12 69.99% <100.00%> (+<0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <12.50%> (-0.04%) ⬇️
3.12 aws_deps 46.23% <12.50%> (-0.04%) ⬇️
3.12 big 54.75% <12.50%> (-0.04%) ⬇️
3.12 bigquery 48.52% <12.50%> (-0.02%) ⬇️
3.12 databricks 50.29% <12.50%> (-0.02%) ⬇️
3.12 filesystem 62.70% <100.00%> (+0.01%) ⬆️
3.12 mssql 51.28% <12.50%> (-0.04%) ⬇️
3.12 mysql 51.69% <12.50%> (-0.04%) ⬇️
3.12 postgresql 54.35% <12.50%> (-0.02%) ⬇️
3.12 snowflake 51.11% <12.50%> (-0.02%) ⬇️
3.12 spark 57.68% <12.50%> (-0.02%) ⬇️
3.12 spark_connect 46.52% <12.50%> (-0.04%) ⬇️
3.12 trino 52.25% <12.50%> (-0.04%) ⬇️
3.9 70.02% <100.00%> (-0.01%) ⬇️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <12.50%> (-0.04%) ⬇️
3.9 aws_deps 46.25% <12.50%> (-0.02%) ⬇️
3.9 big 54.77% <12.50%> (-0.04%) ⬇️
3.9 bigquery 48.51% <12.50%> (-0.02%) ⬇️
3.9 clickhouse 43.14% <12.50%> (-0.02%) ⬇️
3.9 databricks 50.29% <12.50%> (-0.02%) ⬇️
3.9 filesystem 62.70% <100.00%> (-0.01%) ⬇️
3.9 mssql 51.27% <12.50%> (-0.04%) ⬇️
3.9 mysql 51.67% <12.50%> (-0.04%) ⬇️
3.9 postgresql 54.33% <12.50%> (-0.02%) ⬇️
3.9 snowflake 51.11% <12.50%> (-0.02%) ⬇️
3.9 spark 57.65% <12.50%> (-0.05%) ⬇️
3.9 spark_connect 46.53% <12.50%> (-0.04%) ⬇️
3.9 trino 52.23% <12.50%> (-0.02%) ⬇️
cloud 0.00% <0.00%> (ø)
docs-basic 53.91% <12.50%> (-0.02%) ⬇️
docs-creds-needed 52.86% <12.50%> (-0.02%) ⬇️
docs-spark 52.34% <12.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshua-stauffer joshua-stauffer changed the title Implement suite factory add_or_update [FEATURE] Implement suite factory add_or_update Dec 19, 2024
@@ -125,3 +125,23 @@ def all(self) -> Iterable[ExpectationSuite]:
self._store.submit_all_deserialization_event(e)
raise
return deserializable_suites

@public_api
def add_or_update(self, suite: ExpectationSuite) -> ExpectationSuite:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a docstring here please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching! meant to do that and missed it. added in 5acc32a

Copy link
Member

@cdkini cdkini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good just asking for the docstring and I'll stamp!

@joshua-stauffer joshua-stauffer added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@joshua-stauffer joshua-stauffer added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@joshua-stauffer joshua-stauffer added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit c534b64 Dec 20, 2024
70 checks passed
@joshua-stauffer joshua-stauffer deleted the f/core-605/suite_factory_add_or_update branch December 20, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants