-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Implement suite factory add_or_update #10796
[FEATURE] Implement suite factory add_or_update #10796
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10796 +/- ##
===========================================
- Coverage 80.70% 80.68% -0.02%
===========================================
Files 465 465
Lines 40433 40449 +16
===========================================
+ Hits 32631 32638 +7
- Misses 7802 7811 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -125,3 +125,23 @@ def all(self) -> Iterable[ExpectationSuite]: | |||
self._store.submit_all_deserialization_event(e) | |||
raise | |||
return deserializable_suites | |||
|
|||
@public_api | |||
def add_or_update(self, suite: ExpectationSuite) -> ExpectationSuite: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a docstring here please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching! meant to do that and missed it. added in 5acc32a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good just asking for the docstring and I'll stamp!
invoke lint
(usesruff format
+ruff check
)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!