[BUGFIX] Ensure datetime.time can be serialized to JSON #10795
Merged
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
for more information, see https://pre-commit.ci
❌ 180 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
tests/test_ge_utils.py
Outdated
Comment on lines
562
to
579
|
|
||
|
|
||
| @pytest.mark.unit | ||
| @pytest.mark.parametrize( | ||
| "data", [pytest.param({"t": datetime.time(hour=1, minute=30, second=45)}, id="datetime.time")] | ||
| ) | ||
| def test_convert_to_json_serializable_converts_correctly(data: dict): | ||
| ret = convert_to_json_serializable(data) | ||
| assert ret == {"t": "01:30:45"} | ||
|
|
||
|
|
||
| @pytest.mark.unit | ||
| @pytest.mark.parametrize( | ||
| "data", [pytest.param({"t": datetime.time(hour=1, minute=30, second=45)}, id="datetime.time")] | ||
| ) | ||
| def test_ensure_json_serializable(data: dict): | ||
| ensure_json_serializable(data) | ||
| # Passes if no exception raised |
There was a problem hiding this comment.
tests look good, but they should probably live in tests.test_convert_to_json_serializable, unless there's a compelling reason to break the pattern.
There was a problem hiding this comment.
Thanks, I'll move. I didn't notice that file assuming we were following the pattern of test file per module
There was a problem hiding this comment.
yeah, that would be super reasonable - at some point we could refactor this to be more logical. thanks for addressing!
joshua-stauffer
requested changes
Dec 19, 2024
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
datetime.timehandling to the serialization code in utils.datetime.timeis now serializable, and serialization is performed by converting it to its ISO format string.invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!