-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Handle DatabricksSQL attribute error and update dependency #10424
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10424 +/- ##
========================================
Coverage 79.96% 79.96%
========================================
Files 459 459
Lines 39976 39976
========================================
Hits 31965 31965
Misses 8011 8011 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
except (ImportError, AttributeError): | ||
sqla_databricks = None # type: ignore[assignment] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this module should probably use our NotImported
pattern. But I don't want to do that as part of this PR.
Depending on the version and extra depenencies the
databricks
package may not always have a.sqlalchemy
sub-module.This PR handles the potential
AttributeError
and bumps the minimum version ofdatabricks-sql-connector