Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add Connect to Databricks SQL page in GX Cloud #10394

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

allisongx
Copy link
Contributor

@allisongx allisongx commented Sep 13, 2024

https://greatexpectations.atlassian.net/browse/LAK-1211

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit a24093a
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66eae4c735e7a900090e94b1
😎 Deploy Preview https://deploy-preview-10394.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (c49d728) to head (a24093a).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10394      +/-   ##
===========================================
- Coverage    79.95%   79.95%   -0.01%     
===========================================
  Files          460      460              
  Lines        39970    39970              
===========================================
- Hits         31958    31957       -1     
- Misses        8012     8013       +1     
Flag Coverage Δ
3.10 66.73% <ø> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark ?
3.10 trino ?
3.11 66.73% <ø> (ø)
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark ?
3.11 trino ?
3.12 65.33% <ø> (-0.02%) ⬇️
3.12 aws_deps 45.88% <ø> (ø)
3.12 big 54.50% <ø> (ø)
3.12 filesystem 60.99% <ø> (ø)
3.12 mssql 49.97% <ø> (ø)
3.12 mysql 50.03% <ø> (ø)
3.12 postgresql 54.28% <ø> (ø)
3.12 spark 57.79% <ø> (ø)
3.12 trino 52.41% <ø> (ø)
3.8 66.77% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 55.09% <ø> (ø)
3.8 aws_deps 45.90% <ø> (ø)
3.8 big 54.52% <ø> (ø)
3.8 databricks 47.60% <ø> (ø)
3.8 filesystem 61.00% <ø> (ø)
3.8 mssql 49.96% <ø> (ø)
3.8 mysql 50.02% <ø> (ø)
3.8 postgresql 54.27% <ø> (ø)
3.8 snowflake 48.46% <ø> (ø)
3.8 spark 57.76% <ø> (ø)
3.8 trino 52.40% <ø> (ø)
3.9 66.75% <ø> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 52.43% <ø> (ø)
docs-creds-needed 52.71% <ø> (ø)
docs-spark 52.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allisongx allisongx marked this pull request as ready for review September 17, 2024 21:17
@allisongx allisongx enabled auto-merge September 17, 2024 21:18

- You have a Databricks SQL catalog, schema, and table.

- To improve data security, GX recommends creating a separate Databricks SQL user for your GX Cloud connection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/user/service principal/ - Per Databricks documentation, a service principal, not a user, should be used for automated tools.

Copy link
Contributor

@Kilo59 Kilo59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @jtimberman suggestion, but otherwise LGTM.

Copy link
Contributor

@jtimberman jtimberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧱🧱🧱🧱🧱 🥳

@allisongx allisongx added this pull request to the merge queue Sep 18, 2024
Merged via the queue into develop with commit 14fb7e8 Sep 18, 2024
62 checks passed
@allisongx allisongx deleted the databricks-sql-docs-update branch September 18, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants