Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update docs for UnexpectedRowsExpectation #10391

Merged
merged 23 commits into from
Sep 19, 2024

Conversation

NathanFarmer
Copy link
Contributor

@NathanFarmer NathanFarmer commented Sep 13, 2024

  • Add Core language indicating that UnexpectedRowsExpectation doesn't need to be subclassed
  • Add Core language indicating that {batch} keyword is optional and improve language describing what it does
  • Add Cloud section for "Custom SQL Expectations"

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@NathanFarmer NathanFarmer self-assigned this Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit b7009df
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66ec587c001d0d000845e02c

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (f567c84) to head (b7009df).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10391      +/-   ##
===========================================
- Coverage    79.98%   79.95%   -0.03%     
===========================================
  Files          459      459              
  Lines        39976    39976              
===========================================
- Hits         31974    31964      -10     
- Misses        8002     8012      +10     
Flag Coverage Δ
3.10 66.73% <ø> (-0.03%) ⬇️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 spark_connect ?
3.10 trino ?
3.11 66.73% <ø> (-0.03%) ⬇️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 spark_connect ?
3.12 65.33% <ø> (-0.03%) ⬇️
3.12 aws_deps 45.88% <ø> (-0.03%) ⬇️
3.12 big 54.50% <ø> (-0.03%) ⬇️
3.12 filesystem 60.99% <ø> (-0.03%) ⬇️
3.12 mssql 49.97% <ø> (-0.03%) ⬇️
3.12 mysql 50.03% <ø> (-0.03%) ⬇️
3.12 postgresql 54.29% <ø> (-0.03%) ⬇️
3.12 spark 57.80% <ø> (ø)
3.12 spark_connect 46.17% <ø> (-0.03%) ⬇️
3.12 trino 52.42% <ø> (ø)
3.8 66.77% <ø> (-0.03%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 55.09% <ø> (-0.03%) ⬇️
3.8 aws_deps 45.91% <ø> (-0.03%) ⬇️
3.8 big 54.52% <ø> (-0.03%) ⬇️
3.8 databricks 47.60% <ø> (ø)
3.8 filesystem 61.00% <ø> (-0.03%) ⬇️
3.8 mssql 49.96% <ø> (-0.03%) ⬇️
3.8 mysql 50.02% <ø> (-0.03%) ⬇️
3.8 postgresql 54.27% <ø> (-0.03%) ⬇️
3.8 snowflake 48.46% <ø> (ø)
3.8 spark 57.77% <ø> (ø)
3.8 spark_connect 46.18% <ø> (-0.03%) ⬇️
3.8 trino 52.41% <ø> (-0.03%) ⬇️
3.9 66.75% <ø> (-0.03%) ⬇️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 spark_connect ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 52.43% <ø> (-0.03%) ⬇️
docs-creds-needed 52.71% <ø> (-0.03%) ⬇️
docs-spark 52.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NathanFarmer NathanFarmer marked this pull request as ready for review September 13, 2024 16:52
@NathanFarmer NathanFarmer requested review from lockettks, dctalbot and josectobar and removed request for Erin-GX September 19, 2024 16:30
@NathanFarmer NathanFarmer added this pull request to the merge queue Sep 19, 2024
Merged via the queue into develop with commit 215b6bf Sep 19, 2024
64 checks passed
@NathanFarmer NathanFarmer deleted the d/ph-1472/custom-sql-expectations-docs branch September 19, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants