Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Additional tests for ValidationDefinition and Checkpoint freshness #10381

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Sep 11, 2024

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 857700d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66e1cda66b0e0f0008cac9f0

except StoreBackendError:
except (
StoreBackendError, # Generic error from stores
InvalidKeyError, # Ephemeral context error
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow up by patching the in-memory stores to return a consistent type

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (72e5c8f) to head (857700d).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10381      +/-   ##
===========================================
+ Coverage    79.85%   79.86%   +0.01%     
===========================================
  Files          460      460              
  Lines        39855    39855              
===========================================
+ Hits         31825    31829       +4     
+ Misses        8030     8026       -4     
Flag Coverage Δ
3.10 66.70% <100.00%> (+0.03%) ⬆️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 trino ?
3.11 66.70% <100.00%> (+0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 trino ?
3.12 65.31% <100.00%> (+0.01%) ⬆️
3.12 aws_deps 45.92% <33.33%> (ø)
3.12 big 54.57% <33.33%> (ø)
3.12 filesystem 61.00% <33.33%> (ø)
3.12 mssql 49.97% <33.33%> (ø)
3.12 mysql 50.03% <33.33%> (ø)
3.12 postgresql 54.24% <33.33%> (ø)
3.12 spark 57.75% <33.33%> (ø)
3.12 trino 52.36% <33.33%> (ø)
3.8 66.74% <100.00%> (+0.03%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.95% <33.33%> (ø)
3.8 aws_deps 45.94% <33.33%> (ø)
3.8 big 54.59% <33.33%> (ø)
3.8 databricks 47.33% <33.33%> (ø)
3.8 filesystem 61.02% <33.33%> (ø)
3.8 mssql 49.96% <33.33%> (ø)
3.8 mysql 50.02% <33.33%> (ø)
3.8 postgresql 54.23% <33.33%> (ø)
3.8 snowflake 48.25% <33.33%> (ø)
3.8 spark 57.72% <33.33%> (ø)
3.8 trino 52.35% <33.33%> (ø)
3.9 66.72% <100.00%> (+0.01%) ⬆️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 trino ?
cloud 0.00% <0.00%> (ø)
docs-basic 52.40% <33.33%> (ø)
docs-creds-needed 52.70% <33.33%> (ø)
docs-spark 52.09% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great! Thanks for adding these tests.

@cdkini cdkini added this pull request to the merge queue Sep 12, 2024
Merged via the queue into develop with commit f3cc379 Sep 12, 2024
67 checks passed
@cdkini cdkini deleted the m/v1-495/equality_checks_tests branch September 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants