-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Additional tests for ValidationDefinition
and Checkpoint
freshness
#10381
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
except StoreBackendError: | ||
except ( | ||
StoreBackendError, # Generic error from stores | ||
InvalidKeyError, # Ephemeral context error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should follow up by patching the in-memory stores to return a consistent type
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10381 +/- ##
===========================================
+ Coverage 79.85% 79.86% +0.01%
===========================================
Files 460 460
Lines 39855 39855
===========================================
+ Hits 31825 31829 +4
+ Misses 8030 8026 -4 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great! Thanks for adding these tests.
invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!