[FEATURE] Add UnexpectedRowsExpectation
#10342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com:great-expectations/great_expectations into f/ph-1522/unexpected-rows-expectation-updates
…_sql_to_define_a_custom_expectation.py
This reverts commit 00a3724.
…b.com:great-expectations/great_expectations into f/ph-1522/unexpected-rows-expectation-updates
NathanFarmer
changed the title
UnexpectedRowsExpectation renderer and validation improvementsUnexpectedRowsExpectation
…ema` and render always `description` over `template_str` (#10347)
NathanFarmer
commented
Sep 10, 2024
Comment on lines
35
to
+43
| query: Optional[str] = metric_value_kwargs.get( | ||
| "query" | ||
| ) or cls.default_kwarg_values.get("query") | ||
| ) or metric_value_kwargs.get("unexpected_rows_query") | ||
|
|
||
| batch_ref = ( | ||
| "batch" | ||
| if metric_value_kwargs.get("unexpected_rows_query") | ||
| else "active_batch" | ||
| ) |
There was a problem hiding this comment.
There is a different pattern than this in v1, but it's not worth the effort to backport that pattern. This is likely one of the last v0 releases.
dctalbot
approved these changes
Sep 10, 2024
NathanFarmer
deleted the
f/ph-1522/unexpected-rows-expectation-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick relevant changes to
UnexpectedRowsExpectationinto0.18.xbranch:UnexpectedRowsExpectationrenderer and validation improvements #10334descriptionfield toExpectationConfigurationSchemaand render alwaysdescriptionovertemplate_str#10347Refactor to follow v0 Expectation patterns
invoke lint(usesruff format+ruff check)