[MAINTENANCE] Refactor Cloud API fake #10238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_expectations into m/v1-470/is_saved
…_expectations into m/v1-470/is_saved
…_expectations into m/v1-470/is_saved
…_expectations into m/v1-470/is_saved
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first pass
use error types
misc updates
update error to share between types
more progress
more progress
more progress
cover cases in vd
misc renames
more cleanup
more cleanup
more cleanup
clean up exceptions
add during run
remove property
update cloud fake
try fixing checkpoint tests
update fake to include assets in ds payload
get checkpoint tests working
batch definition test
suite test
more unit tests
more unit tests
tests around running
refactor tests
Description of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted - run
invoke lint(usesruff format+ruff check)Appropriate tests and docs have been updated
For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!