[MAINTENANCE] Update import path for UnexpectedRowsExpectation #10234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-hoffman
changed the title
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10234 +/- ##
===========================================
+ Coverage 79.00% 79.61% +0.61%
===========================================
Files 454 454
Lines 39458 39458
===========================================
+ Hits 31174 31416 +242
+ Misses 8284 8042 -242 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
NathanFarmer
approved these changes
Aug 19, 2024
tyler-hoffman
commented
Aug 19, 2024
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| # <snippet name="docs/docusaurus/docs/snippets/unexpected_row_expectation.py define_custom_expectation"> | |||
| class UnexpectedTripDistance(UnexpectedRowsExpectation): | |||
| unexpected_rows_query = """ | |||
| unexpected_rows_query: str = """ | |||
There was a problem hiding this comment.
mypy doesn't understand this as a field without the type hint 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to import
UnexpectedRowsExpectationthe way we do other Expectations.invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!