-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Puts 1.0 example scripts for connecting to dataframe data under test. #10225
[DOCS] Puts 1.0 example scripts for connecting to dataframe data under test. #10225
Conversation
…R that hasn't merged yet.
…de this` above them. Intended for including hidden asserts and set up content when putting code under test.
…to dataframe data" guidance.
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10225 +/- ##
===========================================
- Coverage 79.67% 79.66% -0.01%
===========================================
Files 454 454
Lines 39507 39507
===========================================
- Hits 31476 31475 -1
- Misses 8031 8032 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
<TabItem value="validate" label="Validation Definition"> | ||
|
||
A Validation Definition's `validate()` method runs an Expectation Suite against a Batch returned by a Batch Definition. Runtime Batch Parameters can be provided to a Validation Definition's `validate()` method to specify the data returned in the Batch. This allows you to validate your dataframe by executing the Expectation Suite included in the Validation Definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validate()
should be run()
in this paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except the spot that references ValidationDefinition.validate
, rather than ValidationDefinition.run
in the text.
…r test. (#10225) Co-authored-by: Tyler Hoffman <[email protected]>
Description
Definition of done
invoke lint
(usesruff format
+ruff check
)