Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add docs tests step to CI #10220

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

JessSaavedra
Copy link
Contributor

@JessSaavedra JessSaavedra commented Aug 15, 2024

Description

  • Add a step to CI to run yarn test in documentation, as it was not included in the process before.

Screenshot

Captura desde 2024-08-17 21-14-40

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 3e722bd
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66c13dd5a39364000837f0d7

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (48a30e0) to head (3e722bd).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10220      +/-   ##
===========================================
+ Coverage    79.54%   79.61%   +0.07%     
===========================================
  Files          454      454              
  Lines        39451    39458       +7     
===========================================
+ Hits         31381    31415      +34     
+ Misses        8070     8043      -27     
Flag Coverage Δ
3.10 66.26% <ø> (+0.07%) ⬆️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 66.26% <ø> (+0.07%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 postgresql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.12 64.79% <ø> (+0.07%) ⬆️
3.12 aws_deps 45.83% <ø> (+0.02%) ⬆️
3.12 big 54.49% <ø> (+0.03%) ⬆️
3.12 filesystem 60.43% <ø> (+<0.01%) ⬆️
3.12 mssql 49.93% <ø> (+<0.01%) ⬆️
3.12 mysql 50.00% <ø> (+<0.01%) ⬆️
3.12 postgresql 54.08% <ø> (+0.01%) ⬆️
3.12 spark 57.55% <ø> (+0.02%) ⬆️
3.12 trino 52.15% <ø> (+0.03%) ⬆️
3.8 66.30% <ø> (+0.07%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.63% <ø> (+0.03%) ⬆️
3.8 aws_deps 45.85% <ø> (+0.02%) ⬆️
3.8 big 54.51% <ø> (+0.03%) ⬆️
3.8 databricks 47.06% <ø> (+0.03%) ⬆️
3.8 filesystem 60.44% <ø> (+<0.01%) ⬆️
3.8 mssql 49.92% <ø> (+<0.01%) ⬆️
3.8 mysql 49.98% <ø> (+<0.01%) ⬆️
3.8 postgresql 54.07% <ø> (+0.01%) ⬆️
3.8 snowflake 47.98% <ø> (+0.03%) ⬆️
3.8 spark 57.52% <ø> (+0.02%) ⬆️
3.8 trino 52.14% <ø> (+0.03%) ⬆️
3.9 66.26% <ø> (+0.07%) ⬆️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 49.70% <ø> (+0.03%) ⬆️
docs-creds-needed 50.03% <ø> (+0.03%) ⬆️
docs-spark 48.72% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessSaavedra JessSaavedra force-pushed the DSB-691_add_docs_test_check_to_ci branch 10 times, most recently from 8a26e9d to e59d05a Compare August 17, 2024 23:59
@JessSaavedra JessSaavedra force-pushed the DSB-691_add_docs_test_check_to_ci branch from 322f342 to 3e722bd Compare August 18, 2024 00:18
Copy link
Member

@josectobar josectobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏽

@JessSaavedra JessSaavedra enabled auto-merge August 20, 2024 16:39
@JessSaavedra JessSaavedra added this pull request to the merge queue Aug 21, 2024
Merged via the queue into develop with commit 741fa7d Aug 21, 2024
66 checks passed
@JessSaavedra JessSaavedra deleted the DSB-691_add_docs_test_check_to_ci branch August 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants