Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add the public api to context.data_source and context.data_source.get #10180

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

billdirks
Copy link
Contributor

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 51ce4a4
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66b50732c228bd000857c01c

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (dae0ecd) to head (51ce4a4).

Files Patch % Lines
...data_context/data_context/abstract_data_context.py 75.00% 2 Missing ⚠️
...xpectations/data_context/store/data_asset_store.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10180      +/-   ##
===========================================
- Coverage    79.22%   79.20%   -0.02%     
===========================================
  Files          456      456              
  Lines        39702    39705       +3     
===========================================
- Hits         31452    31447       -5     
- Misses        8250     8258       +8     
Flag Coverage Δ
3.10 65.83% <85.71%> (+<0.01%) ⬆️
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 65.83% <85.71%> (+<0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mssql ?
3.11 mysql ?
3.11 snowflake ?
3.11 spark ?
3.11 trino ?
3.12 64.39% <85.71%> (-0.02%) ⬇️
3.12 aws_deps 45.56% <71.42%> (+<0.01%) ⬆️
3.12 big 54.27% <80.95%> (+<0.01%) ⬆️
3.12 filesystem 60.06% <76.19%> (+<0.01%) ⬆️
3.12 mssql 49.67% <71.42%> (+<0.01%) ⬆️
3.12 mysql 49.73% <71.42%> (+<0.01%) ⬆️
3.12 postgresql 53.88% <71.42%> (+<0.01%) ⬆️
3.12 spark 57.20% <80.95%> (+<0.01%) ⬆️
3.12 trino 51.79% <76.19%> (+<0.01%) ⬆️
3.8 65.87% <85.71%> (+<0.01%) ⬆️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.29% <80.95%> (+<0.01%) ⬆️
3.8 aws_deps 45.59% <71.42%> (+<0.01%) ⬆️
3.8 big 54.29% <80.95%> (+<0.01%) ⬆️
3.8 databricks 46.75% <71.42%> (+<0.01%) ⬆️
3.8 filesystem 60.08% <76.19%> (+<0.01%) ⬆️
3.8 mssql 49.65% <71.42%> (+<0.01%) ⬆️
3.8 mysql 49.72% <71.42%> (+<0.01%) ⬆️
3.8 postgresql 53.86% <71.42%> (+<0.01%) ⬆️
3.8 snowflake 47.66% <71.42%> (+<0.01%) ⬆️
3.8 spark 57.17% <80.95%> (+<0.01%) ⬆️
3.8 trino 51.78% <76.19%> (+<0.01%) ⬆️
3.9 65.85% <85.71%> (+<0.01%) ⬆️
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <0.00%> (ø)
docs-basic 49.21% <66.66%> (+<0.01%) ⬆️
docs-creds-needed 49.73% <66.66%> (+<0.01%) ⬆️
docs-spark 48.42% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -251,7 +251,7 @@ def __init__(self, runtime_environment: Optional[dict] = None) -> None:
submit_event(event=DataContextInitializedEvent())

def _init_factories(self) -> None:
self._data_sources: _SourceFactories = _SourceFactories(self)
self._data_sources: DataSourceManager = DataSourceManager(self)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@billdirks billdirks added this pull request to the merge queue Aug 8, 2024
Merged via the queue into develop with commit 173d15c Aug 8, 2024
68 checks passed
@billdirks billdirks deleted the f/_/context.data_source_public branch August 8, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants