-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add the public api to context.data_source and context.data_source.get #10180
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10180 +/- ##
===========================================
- Coverage 79.22% 79.20% -0.02%
===========================================
Files 456 456
Lines 39702 39705 +3
===========================================
- Hits 31452 31447 -5
- Misses 8250 8258 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -251,7 +251,7 @@ def __init__(self, runtime_environment: Optional[dict] = None) -> None: | |||
submit_event(event=DataContextInitializedEvent()) | |||
|
|||
def _init_factories(self) -> None: | |||
self._data_sources: _SourceFactories = _SourceFactories(self) | |||
self._data_sources: DataSourceManager = DataSourceManager(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!