Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] update_datasource returns the updated datasource #10170

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

tyler-hoffman
Copy link
Contributor

Part of the work for #10155.

The resulting datasource will have ids on the nested models. This facilitates datasource.add_batch_definition returning fully formed BatchDefinitions.

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 3ba5d7d
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/66b13ecd0415880008728693

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (2adc446) to head (3ba5d7d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10170   +/-   ##
========================================
  Coverage    78.77%   78.78%           
========================================
  Files          456      456           
  Lines        39725    39722    -3     
========================================
- Hits         31295    31293    -2     
+ Misses        8430     8429    -1     
Flag Coverage Δ
3.10 65.76% <100.00%> (-0.01%) ⬇️
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 65.76% <100.00%> (-0.01%) ⬇️
3.11 aws_deps ?
3.11 big ?
3.11 databricks ?
3.11 filesystem ?
3.11 mysql ?
3.11 snowflake ?
3.11 trino ?
3.12 64.32% <100.00%> (-0.01%) ⬇️
3.12 aws_deps 45.54% <100.00%> (-0.01%) ⬇️
3.12 big 54.26% <100.00%> (-0.01%) ⬇️
3.12 filesystem 60.04% <100.00%> (-0.01%) ⬇️
3.12 mysql 49.71% <0.00%> (+<0.01%) ⬆️
3.12 postgresql 53.85% <100.00%> (-0.01%) ⬇️
3.12 spark 57.00% <100.00%> (-0.01%) ⬇️
3.12 trino 51.77% <100.00%> (-0.01%) ⬇️
3.8 65.80% <100.00%> (-0.01%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.27% <100.00%> (-0.01%) ⬇️
3.8 aws_deps 45.57% <100.00%> (-0.01%) ⬇️
3.8 big 54.28% <100.00%> (-0.01%) ⬇️
3.8 databricks 46.72% <100.00%> (-0.01%) ⬇️
3.8 filesystem 60.05% <100.00%> (-0.01%) ⬇️
3.8 mysql 49.69% <0.00%> (+<0.01%) ⬆️
3.8 postgresql 53.84% <100.00%> (-0.01%) ⬇️
3.8 snowflake 47.64% <100.00%> (-0.01%) ⬇️
3.8 spark 56.97% <100.00%> (-0.01%) ⬇️
3.8 trino 51.76% <100.00%> (-0.01%) ⬇️
3.9 65.78% <100.00%> (-0.01%) ⬇️
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 trino ?
cloud 0.00% <0.00%> (ø)
docs-spark 48.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyler-hoffman tyler-hoffman enabled auto-merge August 5, 2024 21:06
@tyler-hoffman tyler-hoffman added this pull request to the merge queue Aug 5, 2024
Merged via the queue into develop with commit 45948be Aug 5, 2024
63 of 67 checks passed
@tyler-hoffman tyler-hoffman deleted the m/v1-406/return-updated-datasource branch August 5, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants