Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Clean up top-level conftest.py #10014

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

cdkini
Copy link
Contributor

@cdkini cdkini commented Jun 6, 2024

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit fcf3629
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/666332a126ab4a000876f7fa

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (221c7e9) to head (fcf3629).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10014   +/-   ##
========================================
  Coverage    79.31%   79.31%           
========================================
  Files          456      456           
  Lines        38928    38928           
========================================
  Hits         30876    30876           
  Misses        8052     8052           
Flag Coverage Δ
3.10 65.68% <ø> (ø)
3.11 65.68% <ø> (+0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.33% <ø> (ø)
3.11 aws_deps 45.54% <ø> (ø)
3.11 big 54.42% <ø> (ø)
3.11 databricks 46.69% <ø> (ø)
3.11 filesystem 60.23% <ø> (ø)
3.11 mssql 49.72% <ø> (ø)
3.11 mysql 49.78% <ø> (ø)
3.11 postgresql 54.00% <ø> (ø)
3.11 snowflake 47.36% <ø> (+<0.01%) ⬆️
3.11 spark 57.26% <ø> (ø)
3.11 trino 51.87% <ø> (ø)
3.8 65.69% <ø> (-0.02%) ⬇️
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 54.34% <ø> (ø)
3.8 aws_deps 45.56% <ø> (ø)
3.8 big 54.43% <ø> (ø)
3.8 databricks 46.71% <ø> (ø)
3.8 filesystem 60.25% <ø> (ø)
3.8 mssql 49.71% <ø> (ø)
3.8 mysql 49.77% <ø> (ø)
3.8 postgresql 53.99% <ø> (ø)
3.8 snowflake 47.38% <ø> (+<0.01%) ⬆️
3.8 spark 57.23% <ø> (ø)
3.8 trino 51.86% <ø> (ø)
3.9 65.70% <ø> (+0.01%) ⬆️
cloud 0.00% <ø> (ø)
docs-basic 48.56% <ø> (ø)
docs-creds-needed 49.63% <ø> (ø)
docs-spark 48.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdkini cdkini added this pull request to the merge queue Jun 7, 2024
Merged via the queue into develop with commit 85a7906 Jun 7, 2024
68 checks passed
@cdkini cdkini deleted the m/_/clean_up_conftest branch June 7, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants