Skip to content

Commit

Permalink
revert
Browse files Browse the repository at this point in the history
  • Loading branch information
cdkini committed Aug 7, 2024
1 parent 1722597 commit e7fdb63
Show file tree
Hide file tree
Showing 38 changed files with 1,144 additions and 332 deletions.
6 changes: 1 addition & 5 deletions .github/teams.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,13 @@ dx:

devrel:
- "@Rachel-Reverie" # Rachel Reverie
- "@austiezr" # Austin Robinson
- "@kwcanuck" # Rob Gray
- "@kyleaton" # Kyle Eaton
- "@rachhouse" # Rachel House
- "@talagluck" # Tal Gluck
- "@r34ctor" # Nevin Tan

core:
- "@DrewHoo" # Drew Hoover
- "@Erin-GX" # Erin Kapp
- "@HaebichanGX" # Haebichan Jung
- "@JennyTee" # Jenny Terlinden
- "@Kilo59" # Gabriel Gore
- "@NathanFarmer" # Nathan Farmer
Expand All @@ -36,14 +32,14 @@ core:
- "@josectobar" # José Tobar
- "@joshua-stauffer" # Josh Stauffer
- "@joshzzheng" # Josh Zheng
- "@jshaikGX" # Javed Shaik
- "@lockettks" # Kim Mathieu
- "@nicgrayson" # Nic Grayson
- "@roblim" # Rob Lim
- "@rreinoldsc" # Robby Reinold
- "@sujensen" # Susan Jensen
- "@tyler-hoffman" # Tyler Hoffman
- "@wookasz" # Łukasz Lempart
- "@annabarr" # Anna Barr

bot:
- "@dependabot"
Expand Down
2 changes: 1 addition & 1 deletion ci/constraints-test/py312-min-install.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
numpy==1.26.0
pandas==2.2.0
pandas<2.2.0
sqlalchemy==2.0.0 # pandas 2 requires sqlalchemy2
45 changes: 28 additions & 17 deletions docs/docusaurus/___test___/wasThisHelpful.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ import userEvent from '@testing-library/user-event'
import '@testing-library/jest-dom';
import WasThisHelpful from "../src/components/WasThisHelpful";

// Todo: replace this with a mock server if we need to do more fetch requests: https://testing-library.com/docs/react-testing-library/example-intro/#full-example
global.fetch = jest.fn(() =>
Promise.resolve({
ok: true
})
);

describe('"Was this Helpful?" section', () => {

const posthog = {
Expand All @@ -23,27 +30,21 @@ describe('"Was this Helpful?" section', () => {
expect(screen.getByText('No')).not.toBeDisabled();
});

test("Buttons should be disabled when 'Yes' button has been clicked", async () => {
test("Buttons should disappear and Thank You alert displayed when Yes is clicked", async () => {
render(
<WasThisHelpful/>
);
await userEvent.click(screen.getByText('Yes'));

expect(screen.getByText('Yes')).toBeDisabled();
expect(screen.getByText('No')).toBeDisabled();
});

test("Buttons should be disabled when 'No' button has been clicked", async () => {
await selectingNoInWasThisHelpful();
await userEvent.click(screen.getByText('Yes'));

expect(screen.getByText('Yes')).toBeDisabled();
expect(screen.getByText('No')).toBeDisabled();
expect(screen.queryByText('Yes')).not.toBeInTheDocument();
expect(screen.queryByText(THANK_YOU_MESSAGE));
});

test("Feedback Modal should pop-up when 'No' button has been clicked", async () => {
await selectingNoInWasThisHelpful();

expect(screen.getByText('Tell us more')).toBeInTheDocument();
expect(screen.queryByText('What is the problem?')).toBeInTheDocument();
});

test("Submit button in Feedback Modal is disabled when description is blank", async () => {
Expand All @@ -60,14 +61,22 @@ describe('"Was this Helpful?" section', () => {
expect(screen.getByText("Submit")).not.toBeDisabled();
});

test("After clicking the submit button, the Feedback modal disappears", async () => {
test("After clicking the submit button, the Feedback modal disappears and Thank You alert displayed", async () => {
await selectingNoInWasThisHelpful();

await completeRequiredFields();

await userEvent.click(screen.getByText("Submit"));

expect(screen.queryByText('Tell us more')).not.toBeInTheDocument();
expect(screen.queryByText('What is the problem?')).not.toBeInTheDocument();
expect(screen.queryByText(THANK_YOU_MESSAGE));
});

test("After clicking No, the Thank You alert is not displayed while the modal is open", async () => {
await selectingNoInWasThisHelpful();

expect(screen.queryByText('What is the problem?')).toBeInTheDocument();
expect(screen.queryByText(THANK_YOU_MESSAGE)).not.toBeInTheDocument();
});

async function selectingNoInWasThisHelpful() {
Expand All @@ -78,11 +87,13 @@ describe('"Was this Helpful?" section', () => {
}

async function completeRequiredFields() {
const descriptionBox = screen.getByPlaceholderText('Provide as much detail as possible about the issue you ' +
'experienced or where improvement is needed. Detailed feedback helps ' +
'us better identify the problem and determine a solution.');
await userEvent.click(screen.getByLabelText('Language Typo'));

const descriptionBox = screen.getByPlaceholderText("Describe the typo that you've found.");

await userEvent.type(descriptionBox, 'I have a problem');
}

});
const THANK_YOU_MESSAGE = "Thank you for helping us improve our documentation!"

});
3 changes: 1 addition & 2 deletions docs/docusaurus/docs/application_integration_support.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ The following table defines the GX Cloud, GX Core, and Community Supported integ
| --------------------- | -------------------------- | ----------------------------------------------------------------------------- | --------------------------------- |
| Data Sources¹ | Snowflake<br/> PostgreSQL² | Snowflake<br/>PostgreSQL<br/>Sqlite<br/>Databricks (SQL)<br/>Spark<br/>Pandas | Redshift<br/>MSSQL<br/>MySQL<br/> |
| Configuration Stores³ | In-app | File system | None |
| Actions | Slack | Slack <br/>Email | None |
| Actions | Slack | Slack <br/>Email | None |
| Credential Store | Environment variables | Environment variables <br/> YAML⁴ | None |
| Orchestrator | Airflow ⁵ | Airflow ⁵ | None |

Expand All @@ -43,7 +43,6 @@ The following table defines the GX components supported by GX Cloud and GX Core.
| Expectations | See [Available Expectations](/cloud/expectations/manage_expectations.md#available-expectations) | See [Expectations Gallery](https://greatexpectations.io/expectations) | See [Legacy Gallery](https://greatexpectations.io/legacy/v1/expectations/) |
| GX Agent | All versions | N/A | N/A |


### Operating systems

The following table defines the operating systems supported by GX Cloud and GX Core.
Expand Down
2 changes: 1 addition & 1 deletion docs/docusaurus/docs/components/_data.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export default {
release_version: 'great_expectations, version 1.0.0a4',
release_version: 'great_expectations, version 1.0.0a5',
min_python: '3.8',
max_python: '3.11'
}
Loading

0 comments on commit e7fdb63

Please sign in to comment.