Fixes after code review

great-expectations · Sep 2, 2024 · 3463eb3 · 3463eb3
1 parent 299eac8
commit 3463eb3
Show file tree

Hide file tree

Showing 8 changed files with 40 additions and 19 deletions.
diff --git a/docs/docusaurus/src/components/LinkCard/styles.module.css b/docs/docusaurus/src/components/LinkCard/styles.module.css
@@ -59,7 +59,7 @@
 [data-theme='dark'] .linkCard {
     background-color: var(--card-background-dark-theme);
     border-color: #4E4E4E;
-    box-shadow: 0 3px 6px #00000029;
+    box-shadow: var(--default-box-shadow);
 }
 
 [data-theme='dark'] :global(.markdown) .linkCard img {

diff --git a/docs/docusaurus/src/components/WasThisHelpful/styles.module.scss b/docs/docusaurus/src/components/WasThisHelpful/styles.module.scss
@@ -219,9 +219,9 @@
 
 [data-theme='dark'] {
     .feedbackCard {
-        background-color: #404041;
-        border-color: #404041;
-        box-shadow: 0 3px 6px #00000029;
+        background-color: var(--payne-gray-color);
+        border-color: var(--payne-gray-color);
+        box-shadow: var(--default-box-shadow);
     }
 
     .feedbackCardTitle {
@@ -252,4 +252,9 @@
         background-color: transparent;
         margin: auto;
     }
+
+    .submitButton:disabled {
+        color: var(--light-gray-dark-theme);
+        background-color: var(--concrete-gray-color);
+    }
 }
diff --git a/docs/docusaurus/src/css/api_docs/pydata-sphinx-theme-modified.scss b/docs/docusaurus/src/css/api_docs/pydata-sphinx-theme-modified.scss
@@ -10813,11 +10813,16 @@ div.literal-block-wrapper div[class*=highlight-] pre {
   box-shadow: none
 }
 
-code.literal {
+code .literal {
   background-color: var(--pst-color-surface);
   border: 1px solid var(--pst-color-on-surface);
   border-radius: .25rem;
-  padding: .1rem .25rem
+  padding: .1rem .25rem;
+}
+
+[data-theme='dark'] code .literal {
+  background-color: var(--nero-black-color);
+  border: 1px solid var(--gray-900);
 }
 
 figure a.headerlink {

diff --git a/docs/docusaurus/src/css/code_block.scss b/docs/docusaurus/src/css/code_block.scss
@@ -1,5 +1,5 @@
 :root {
-  --code-snippets-title-color: #FAFAFA;
+  --code-snippets-title-color: var(--pale-white-color);
   --code-snippets-title-background-color: #292F43;
 }
 

diff --git a/docs/docusaurus/src/css/custom.scss b/docs/docusaurus/src/css/custom.scss
@@ -23,12 +23,12 @@
 
 /* You can override the default Infima variables here. */
 :root {
-    --ifm-font-color-base: #404041;
-    --ifm-navbar-link-color: #404041;
-    --ifm-menu-color: #404041;
+    --ifm-font-color-base: var(--payne-gray-color);
+    --ifm-navbar-link-color: var(--payne-gray-color);
+    --ifm-menu-color: var(--payne-gray-color);
     --ifm-footer-title-color: #FF8D3A;
     --ifm-footer-link-color: #F8F8F8;
-    --ifm-footer-background-color: #404041;
+    --ifm-footer-background-color: var(--payne-gray-color);
     --ifm-color-primary: #ff6310;
     --ifm-color-primary-dark: #fd326b;
     --ifm-color-primary-darker: #fc215f;
@@ -105,6 +105,12 @@
       --dark-orange-dark-theme: #66371D;
       --card-background-dark-theme: #3C3C3C;
       --light-gray-dark-theme: #6E6E6E;
+      --payne-gray-color: #404041;
+      --pale-white-color: #FAFAFA;
+      --nero-black-color: #262626;
+      --concrete-gray-color: #363637;
+
+      --default-box-shadow: 0 3px 6px #00000029;
 }
 
 .markdown a,
@@ -118,7 +124,7 @@ p > a {
 }
 
 h3 {
-    color: #404041;
+    color: var(--payne-gray-color);
 }
 
 [data-theme='dark'] .markdown img{
@@ -307,11 +313,11 @@ li p + ol {
 }
 
 :root[data-theme='dark'] {
-  --ifm-font-color-base: #FAFAFA;
-  --ifm-navbar-link-color: #FAFAFA;
-  --ifm-menu-color: #FAFAFA;
-  --ifm-background-color: #262626;
-  --ifm-navbar-background-color: #262626;
+  --ifm-font-color-base: var(--pale-white-color);
+  --ifm-navbar-link-color: var(--pale-white-color);
+  --ifm-menu-color: var(--pale-white-color);
+  --ifm-background-color: var(--nero-black-color);
+  --ifm-navbar-background-color: var(--nero-black-color);
 }
 
 [data-theme='dark'] .markdown h3{

diff --git a/docs/docusaurus/src/css/overview_pages.scss b/docs/docusaurus/src/css/overview_pages.scss
@@ -1,5 +1,5 @@
 @mixin overview-card-container {
-  background-color: #404041;
+  background-color: var(--payne-gray-color);
   color: var(--ifm-footer-link-color);
   margin-bottom: 2rem;
   padding: 2.5rem 3rem 2rem;

diff --git a/docs/docusaurus/src/theme/Footer/Layout/index.js b/docs/docusaurus/src/theme/Footer/Layout/index.js
@@ -1,5 +1,7 @@
 import React from 'react';
 import clsx from 'clsx';
+import styles from './styles.module.css';
+
 export default function FooterLayout({style, links, logo, copyright}) {
   return (
     <footer
@@ -76,7 +78,7 @@ export default function FooterLayout({style, links, logo, copyright}) {
           >
             <div>{copyright}</div>
             <div>
-              <a href="https://greatexpectations.io/privacy-policy">Privacy Policy</a>
+              <a className={styles.privacyPolicy} href="https://greatexpectations.io/privacy-policy">Privacy Policy</a>
             </div>
           </div>
       </div>

diff --git a/docs/docusaurus/src/theme/Footer/Layout/styles.module.css b/docs/docusaurus/src/theme/Footer/Layout/styles.module.css
@@ -0,0 +1,3 @@
+.privacyPolicy {
+    color: var(--pale-white-color);
+}