Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current font download with Python script #5052

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Jan 11, 2025

After recent comments / mentions on my earlier PR #4893 and seeing switch2osm/switch2osm#278 , I'm proposing a smaller change

This PR:

  • adds get-fonts.py , a Python script using the same source as the current get-fonts.sh ; we can recommend this method for current installs and future PRs / maintenance
  • uses working URLs for CJK and Noto Emoji fonts
  • comments that get-fonts.sh is deprecated, but leaves it in the repo in case to minimize changes
  • replaces no fonts (I want to upgrade Noto Arabic, but can save this for future changes to the Python script)

Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good step forward on the matter, starting with converting the download script to python and fixing the download errors. Further improvements can be made in subsequent changes.

@imagico imagico merged commit 4a9b5a6 into gravitystorm:master Jan 16, 2025
2 checks passed
@mapmeld mapmeld deleted the python-fonts branch January 16, 2025 20:48
@imagico
Copy link
Collaborator

imagico commented Jan 16, 2025

Thanks a lot for this - it brings us a big step forward regarding the fonts management.

Further steps can be discussed in #5043.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants