-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making pitch and track color less dominant #2363
Conversation
I'm going to merge it if in a few days if no one will oppose. |
This happens sometimes (like in #2409), but I definitely won't push anything when there are any objections.
I consider it to be rather objection than just lack of interest, so now I don't plan any action here. |
No, you shouldn't merge this without review from someone else |
Neither is the case - i am just not able to form a qualified opinion here. I would not change the color this way but i would also not have changed the playground color the way it was changed or the dog_park color. So i can't really say if i consider this change in isolation as good or bad. So i am fine if this change finds general approval - but i would appreciate it of course if - in line with #2270 - someone can explain the guiding principles behind these color choices then. |
I commented on that in #2436 (comment), but my message likely crossed your message (and @kocio-pl's comment). Of course, everything is open for discussion, but let's keep discussing the principles separate from discussing this PR. |
Resolves #1190.
The color definition is not absolute for now to make it easier to test modifications. When it'll be ready to merge, I will remove the "[WIP]" (work in progress) from the title.
After some testing I feel this color (lighten 8%, desaturate 5%) is the best on typical backgrounds:
z14 - it's still visible on the sport center and on the ground, but less than a forest, and small spots on residential area are not a problem now:
Before
After
z15 - pitches are less intense than a special building and secondary roads, now they are more or less like a regular buildings, which is good:
Before
After
z16 - when school areas are bigger, it's the same as with sport centres, and we have a special case, pitch on the residential area, which also looks OK on this zoom level:
Before
After
z17 - another typical background, pitch on a grass, you can also see that it's still much different than cemetery green:
Before
After