Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shop=sports icon #1707

Closed
wants to merge 1 commit into from
Closed

Conversation

kocio-pl
Copy link
Collaborator

Resolves #1530.

New icon alone and in comparison with shop=clothes:
sports-alone
sports-clothes

@RobJN
Copy link

RobJN commented Aug 1, 2015

Doesn't say "sport" to me - still says clothes. Why not try a ball or similar.

@matkoniecz
Copy link
Contributor

For me it is good icon for shop=sport_clothes, not shop=sport.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 2, 2015

Another idea:
2) sports-14-13
sports-cup

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 4, 2015

@RobJN Ball was hard to be drawn in such a small space, but I also don't like to use attributes of any kind of sport because I think we may start adding icons for different sport objects. You can read more about problems with creating right sport icon in the corresponding issue.

@mboeringa
Copy link

I am fine with the original "cloth" type proposal with shorts. Shorts are quite strongly associated with "sport". The second icon has a conflict with the archaeological site icon, and is less signifying.

For me it is good icon for shop=sport_clothes, not shop=sport.

What's the supposed difference? I doubt people could differentiate, all shops related to sport, except maybe those specialized ones selling trophies, sell clothes... And the official tag seems shop=sports ;) (http://wiki.openstreetmap.org/wiki/Key:shop), shop=sport_clothes is not even listed on the Wiki...

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 4, 2015

@mboeringa It was in fact derived from archaeological site icon and I was thinking about making it even more slim (like this one), but first I wanted to know if this metaphor is acceptable at all. BTW: archaeological icon is amenity-brown, while sports will be shop-violet, so I don't think it could be misleading.

Maybe single item is too hard to use as an icon - we can resort to multiple objects, as I have already proposed in #1530, but I want to test every possible way to have something more clear.

@kocio-pl
Copy link
Collaborator Author

Slimmed down version with more typical foot:
sports-cup-tall

@matthijsmelissen
Copy link
Collaborator

Would something like sport-icon work?

@kocio-pl
Copy link
Collaborator Author

One of my draft was a football ball, but it was unrecognizable, given the available pixel resolution, so I guess this one would be even worse, because there were patches and there are thin lines.

However I don't like the idea of showing any particular sport discipline as a general symbol, because I foresee they might be needed in the future for different sport facilities (like pitches for example) and strongly prefer something neutral in this regard. It would be better to have one piece like this one, but if not, the collection of different symbols is acceptable for me (just less clean).

@kocio-pl
Copy link
Collaborator Author

I have just checked that leisure=sports_centre has no icon, so I'd like to reserve collection of symbols for it, because that will encourage people to tag it more precisely (with sport=*).

@mboeringa
Copy link

Slimmed down version with more typical foot:

If you want to stick with the "cup" metaphor, that is indeed an improvement. It looks more like a winning cup instead of an ancient amphora, and I think it now has enough distinction combined with the different colour.

@kocio-pl
Copy link
Collaborator Author

Yes, I think it's decent enough now and I like it this way.

@matkoniecz
Copy link
Contributor

The problem is that it is meaning is not obvious - what is problematic enough for me to not merge it but not enough to reject it (as icon is fitting this shop type).

Unfortunately I have no idea for a better icon and cup icon is the best one from already proposed.

@kocio-pl
Copy link
Collaborator Author

I have already wrote down all my arguments regarding "obviousness" and why it's overrated and inconsistent (see here for example), but nobody have even tried to discuss with them (which is a big surprise for me!). I guess it means it's probably just a matter of personal feelings - and I see no way to really discuss them... 😶

@imagico
Copy link
Collaborator

imagico commented Sep 11, 2015

what is problematic enough for me to not merge it but not enough to reject it.

I think it helps to look at the balance in terms of solving problems adding problems. Here:

Solved:

  • it would solve the problem that a certain type of shop is not indicated with a specific symbol and thereby adds useful semantic information to the map.

Added:

  • it adds an additional type of icon making the map as a whole more difficult to read.
  • it adds ambiguity and confusion by use of a symbol that is no clearly associated by most people with the type of feature it illustrates (people don't go to a sports shop to buy cups, at least not AFAIK).

Which weights more is a matter of opinion of course.

@mrwojo
Copy link
Contributor

mrwojo commented Sep 11, 2015

The icon looks specifically like shop=trophy. (That tag is underrepresented in OSM. There's far more than 48 of those in the real world.)

@kocio-pl
Copy link
Collaborator Author

@imagico I would describe it in a different way, with more specific gains than just one big "more informations" on the positive side. For me it involves wider context (like "makes high zoom levels more usable"), because I also care for consistency (what about other equally not clear icons/lines/patterns we already have - should we remove vineyard pattern or any road colors, because they are not clear just by looking at them?) and the relations with the rest of ecosystem (they're very popular, so it's probably important for the people to see them different than a standard shop). But you're right - in the end kind of +/- list might help when in doubt.

There's also multiple-objects version available. I just like it less and I think it could be used for something different, but it's still not being used and those items are what you can really see in such a shop.

@mrwojo There are basket shops, which would be more relevant for current "convenience" icon, yet I think the look is much less important factor than popularity - and lack of better alternatives probably. Which is exactly the same as in this case (trophy shops are less popular than general sports shops anyway).

@kocio-pl
Copy link
Collaborator Author

Interesting example from MapQuest Open: shop=sports+sport=skying is visible from z=13 and before I have checked it, I thought it's a grit bin. However under the closer inspection it looks like a side effect of trying to show snow sports pitch without checking if it's a pitch at all.

@matthijsmelissen
Copy link
Collaborator

Unfortunately I don't think the current symbol is recognizable enough - test person also thinks it sells trophies rather than sport articles.

If anybody has a good idea, please let us know!

@kocio-pl kocio-pl deleted the sports-icon branch September 27, 2015 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants