Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shop=computer icon #1616

Merged
merged 1 commit into from
Jul 19, 2015

Conversation

kocio-pl
Copy link
Collaborator

Resolves #1416 .

computer-z19

@nebulon42
Copy link
Contributor

I promised to notify you when I have created a similar icon: https://github.com/nebulon42/osmic/blob/master/shop/computer-14.svg

@kocio-pl
Copy link
Collaborator Author

Thanks. =} Could you make a rendering to compare it easier? The concept is basically the same, so details matter, I guess.

@nebulon42
Copy link
Contributor

Here:
computer

@kocio-pl
Copy link
Collaborator Author

It's less clear at this scale, but might work (probably I should copy your screen anyway). I guess more opinions would be needed to make the decision.

@nebulon42
Copy link
Contributor

Yes, that is to be expected because I added more detail.

@kocio-pl
Copy link
Collaborator Author

I think that's rather because of the bottom part, where I have used more of perspective for the keyboard. I like your details here very much (clever!), we just have so limited space here that keeping the whole design nice at higher resolutions bites the readability at lower ones. This is a borderline case for me - I'm not sure if it's recognizable enough.

@nebulon42
Copy link
Contributor

For me it's still acceptable, but you are right about bigger vs smaller sizes. I have to make sure that my icons look okay at nearly all sizes, because uses might differ. They are intended for 14px, but in the font they could be used at virtually every size. Icons that are intended for osm-carto only, don't have this requirement.

@matthijsmelissen matthijsmelissen merged commit c6889a0 into gravitystorm:master Jul 19, 2015
@kocio-pl kocio-pl deleted the computer-icon branch July 19, 2015 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants