Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shop=toys icon #1569

Merged
merged 1 commit into from
May 29, 2015
Merged

Conversation

kocio-pl
Copy link
Collaborator

Resolves #1414.

toys-after-z19

@nebulon42
Copy link
Contributor

Not bad. The icon has a small stroke, which should be removed because the shop colour does not get applied to it. Some things that come to my mind: maybe have the ears more distinct, add a round hole for an "eye" and make the tail look more horse-like.

@kocio-pl
Copy link
Collaborator Author

toys-after-z19-nebulon

I knew there's something strange! - but was too tired already to check the stroke...

Any bigger ears will destroy the silhouette of the SVG (see my remarks with the shop=chemist) and even too big eye on SVG is not to be spotted on PNG, so I didn't touch it. Tail is thicker, but I'm afraid that the space below it will disappear - for now it's acceptable.

@nebulon42
Copy link
Contributor

Looks better, now the bottom is a bit fragile but I didn't check how much compromises are necessary to fit it into the small rectangle.

@daganzdaanda
Copy link

Overall a really nice icon! Maybe the bottom quarter-circle could be thicker, but that's not important.

@kocio-pl
Copy link
Collaborator Author

Even better, thanks! - toys-14

@kocio-pl
Copy link
Collaborator Author

I still don't know how to squash latest commits into one... Sorry for the mess.

git reset --hard HEAD~ + git merge --squash HEAD@{1} + git commit + git push

gives me the information that origin and local branches have diverged, and after pulling git push makes another commits in origin....

[EDIT:] git push -f (force) helped... However git rebase --squash-recent would be much better... =}

@kocio-pl
Copy link
Collaborator Author

@nebulon42 I was not aware you're making Osmic version of this icon - don't you want to get it here? Mine is OK, but yours is probably better and it fits into the style of some others, so I would prefer it for better visual consistency.

@nebulon42
Copy link
Contributor

When I looked at the horse in detail I found myself re-drawing it, but I don't plan to make additional icon PRs for now other than replacing existing symbols. If you feel it fits better, feel free to use it!

@kocio-pl
Copy link
Collaborator Author

I will stay with my latest icon, because I forgot to check PNG and while Osmic SVG is clearly better, the resulting PNG was harder to recognize.

toys-z19-bold

@nebulon42
Copy link
Contributor

How comes PNG into play here?

@kocio-pl
Copy link
Collaborator Author

SVGs are converted into raster form, PNG is just a form of showing it: toys-14-osmic - especially head is too small for me.

@matthijsmelissen matthijsmelissen merged commit ee124c6 into gravitystorm:master May 29, 2015
@kocio-pl kocio-pl deleted the toys-icon branch June 24, 2015 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add special rendering for shop=toys
4 participants