-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shop=toys icon #1569
Adding shop=toys icon #1569
Conversation
Not bad. The icon has a small stroke, which should be removed because the shop colour does not get applied to it. Some things that come to my mind: maybe have the ears more distinct, add a round hole for an "eye" and make the tail look more horse-like. |
I knew there's something strange! - but was too tired already to check the stroke... Any bigger ears will destroy the silhouette of the SVG (see my remarks with the shop=chemist) and even too big eye on SVG is not to be spotted on PNG, so I didn't touch it. Tail is thicker, but I'm afraid that the space below it will disappear - for now it's acceptable. |
Looks better, now the bottom is a bit fragile but I didn't check how much compromises are necessary to fit it into the small rectangle. |
Overall a really nice icon! Maybe the bottom quarter-circle could be thicker, but that's not important. |
I still don't know how to squash latest commits into one... Sorry for the mess. git reset --hard HEAD~ + git merge --squash HEAD@{1} + git commit + git push gives me the information that origin and local branches have diverged, and after pulling git push makes another commits in origin.... [EDIT:] git push -f (force) helped... However git rebase --squash-recent would be much better... =} |
@nebulon42 I was not aware you're making Osmic version of this icon - don't you want to get it here? Mine is OK, but yours is probably better and it fits into the style of some others, so I would prefer it for better visual consistency. |
When I looked at the horse in detail I found myself re-drawing it, but I don't plan to make additional icon PRs for now other than replacing existing symbols. If you feel it fits better, feel free to use it! |
How comes PNG into play here? |
Resolves #1414.