Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NET-1540): add cfg to autoclose connections on rac, when logged out #3130

Merged

Conversation

Aceix
Copy link
Contributor

@Aceix Aceix commented Sep 17, 2024

Describe your changes

only auto-disconnect non-admin users when JWT expires on RAC

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@Aceix Aceix requested a review from abhishek9686 September 17, 2024 01:15
@Aceix Aceix force-pushed the kwesi/net-1540-rac-detect-and-cleanup-stale-interfaces-2 branch from 5347bdf to ccf5bc8 Compare September 20, 2024 11:49
only auto-disconnect non-admin users when JWT expires on RAC and RAC_AUTO_DISABLE is set
@Aceix Aceix force-pushed the kwesi/net-1540-rac-detect-and-cleanup-stale-interfaces-2 branch from ccf5bc8 to 5fc9c04 Compare October 7, 2024 09:25
@abhishek9686 abhishek9686 merged commit ce7c164 into develop Oct 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants