Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NET-786): enhance enrollment key validation #2726

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix(NET-786): enhance enrollment key validation #2726

merged 1 commit into from
Jan 3, 2024

Conversation

Aceix
Copy link
Contributor

@Aceix Aceix commented Dec 11, 2023

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@Aceix Aceix force-pushed the kwesi/net-786-bug-enrollment-key-duplicate-name-is-p branch from e8c2a06 to 2642a28 Compare December 11, 2023 14:55
abhishek9686
abhishek9686 requested changes Dec 15, 2023
View reviewed changes
models/enrollment_key.go Outdated Show resolved Hide resolved
@Aceix Aceix force-pushed the kwesi/net-786-bug-enrollment-key-duplicate-name-is-p branch from 2642a28 to 293d7e7 Compare December 15, 2023 11:42
@Aceix Aceix requested a review from abhishek9686 December 15, 2023 11:43
abhishek9686
abhishek9686 requested changes Dec 15, 2023
View reviewed changes
controllers/enrollmentkeys.go Outdated Show resolved Hide resolved
@Aceix Aceix force-pushed the kwesi/net-786-bug-enrollment-key-duplicate-name-is-p branch from 293d7e7 to dbe58a4 Compare December 15, 2023 14:54
@Aceix Aceix requested a review from abhishek9686 December 15, 2023 14:54
@abhishek9686 abhishek9686 merged commit 033e203 into develop Jan 3, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishek9686 abhishek9686 abhishek9686 approved these changes

@mattkasun mattkasun Awaiting requested review from mattkasun

@afeiszli afeiszli Awaiting requested review from afeiszli

@pwilson77 pwilson77 Awaiting requested review from pwilson77

@theguy951357 theguy951357 Awaiting requested review from theguy951357

@uGiFarukh uGiFarukh Awaiting requested review from uGiFarukh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aceix @abhishek9686