Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loadBalancingConfig instead of loadBalancingPolicy #51428

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Jan 23, 2025
@codingllama codingllama requested a review from tigrato January 23, 2025 18:38
@codingllama
Copy link
Contributor Author

I was looking at the new breaking changes on grpc v1.70.0, which led me to lookup our ServiceConfigs, which led me to this. The loadBalancingPolicy setting doesn't cause problems, afaik, but I thought better to get ahead of it.

For those curious: https://github.com/grpc/grpc-go/releases/tag/v1.70.0.

@codingllama codingllama added this pull request to the merge queue Jan 24, 2025
Merged via the queue into master with commit 911df3e Jan 24, 2025
43 checks passed
@codingllama codingllama deleted the codingllama/grpc-lbconfig branch January 24, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants