[Web] Add access list notification type #51426
Open
+352
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
rudream
force-pushed
the
yassine/access-list-notification-type
branch
from
3e92962 to
e9bc87e
Compare
kimlisa
reviewed
Jan 23, 2025
There was a problem hiding this comment.
i kinda wish you included the logic that will use these, b/c to me NotificationAccessListReviewXXX and NotificationIdentifierPrefixAccessListXXX both look unique to me? or i guess i dont understand the use for NotificationIdentifierPrefixAccessListXXX?
There was a problem hiding this comment.
The prefix isn't a notification subkind, it's just the prefix for the "unique notification identifier" resource which will be mapped to these notifications to prevent duplicates.
For more context see this PR: #51358
Comment on lines
+310
to
+313
| case *notificationsv1.GlobalNotificationSpec_ByUsers: | ||
| userList := matcher.ByUsers.GetUsers() | ||
| return slices.Contains(userList, authCtx.User.GetName()) | ||
|
|
There was a problem hiding this comment.
is there a test for this? or exclude this change?
avatus
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
ecounterpart: https://github.com/gravitational/teleport.e/pull/5922Adds a new notification type for access list reminder notifications. The logic that creates these notifications will be in a separate PR.
Demo