[vnet] add windows tsh cli commands #50935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the VNet tsh CLI commands and adds stubs for the commands that are going to be added for Windows VNet support.
github-actions
bot
added
size/sm
tsh
|
Does this include the feedback that Alan left on #50468? Maybe it'd make sense to take Noah and Bartosz out of this PR and assign it to Alan too? |
codingllama
approved these changes
Jan 13, 2025
tool/tsh/common/vnet.go
Outdated
| @@ -0,0 +1,94 @@ | |||
| // Teleport | |||
| // Copyright (C) 2024 Gravitational, Inc. | |||
There was a problem hiding this comment.
Friendly reminder to update your templates (if any) to 2025. I suppose this was written in 2024 so it's probably fine? (Obligatory I'm not a lawyer.)
rosstimothy
approved these changes
Jan 13, 2025
tool/tsh/common/vnet.go
Outdated
Comment on lines
57
to
60
| go func() { | ||
| <-cf.Context.Done() | ||
| processManager.Close() | ||
| }() |
There was a problem hiding this comment.
You could alternatively use context.AfterFunc.
public-teleport-github-review-bot
bot
removed request for
ravicious,
bl-nero and
strideynet
nklaassen
added
the
no-changelog
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly refactors the VNet tsh CLI commands and adds stubs for the commands that are going to be added for Windows VNet support.