Remove logrus dependency #50930
Merged
Remove logrus dependency #50930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
force-pushed
the
tross/slog_integrations
branch
from
cbc8fd5 to
867796d
Compare
rosstimothy
force-pushed
the
tross/remove_slog
branch
2 times, most recently
from
5635afa to
e59bfba
Compare
rosstimothy
force-pushed
the
tross/slog_integrations
branch
from
867796d to
4b49400
Compare
rosstimothy
force-pushed
the
tross/remove_slog
branch
2 times, most recently
from
c085e39 to
fca0128
Compare
avatus
approved these changes
Jan 10, 2025
tigrato
approved these changes
Jan 10, 2025
public-teleport-github-review-bot
bot
removed request for
probakowski and
camscale
This is the _last_ step required to migrate from logrus to slog. All components in the repository have been migrated to use slog allowing the logrus formatter to be deleted. The slog handler tests that validate the output have been updated to assert the format directly instead of comparing it to the output from the logrus formatter.
rosstimothy
force-pushed
the
tross/remove_slog
branch
from
fca0128 to
2fbbc05
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step required to migrate from logrus to slog. All components in the repository have been migrated to use slog allowing the logrus formatter to be deleted.
The slog handler tests that validate the output have been updated to assert the format directly instead of comparing it to the output from the logrus formatter.