Refactor lib/tbot/spiffe to use WorkloadAttrs proto
#50833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
added
no-changelog
strideynet
force-pushed
the
strideynet/refactor-tbot-internals-around-attrs
branch
2 times, most recently
from
85accc5 to
68eebba
Compare
timothyb89
approved these changes
Jan 13, 2025
strideynet
force-pushed
the
strideynet/refactor-tbot-internals-around-attrs
branch
from
68eebba to
467a4cb
Compare
ryanclark
approved these changes
Jan 15, 2025
public-teleport-github-review-bot
bot
removed the request for review
from vapopov
strideynet
force-pushed
the
strideynet/refactor-tbot-internals-around-attrs
branch
from
467a4cb to
bc2ce53
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
strideynet
deleted the
strideynet/refactor-tbot-internals-around-attrs
branch
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Jan 15, 2025
* Refactor `lib/tbot/spiffe` to use WorkloadAttrs proto * Refactor existing Workload API and SDS services to use new attr protos
strideynet
added a commit
that referenced
this pull request
Jan 15, 2025
* Refactor `lib/tbot/spiffe` to use WorkloadAttrs proto * Refactor existing Workload API and SDS services to use new attr protos
This was referenced Jan 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Refactor `lib/tbot/spiffe` to use WorkloadAttrs proto * Refactor existing Workload API and SDS services to use new attr protos
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Refactor `lib/tbot/spiffe` to use WorkloadAttrs proto * Refactor existing Workload API and SDS services to use new attr protos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #49986
As per RFD191: #49133
Depends on #50812
A wholly internal refactor of
tbotto use the new Workload Identity attribute protos. This sets the stage for the next PR which will introduce the newtbotservice for the SPIFFE Workload API and the new Workload Identity UX.This PR shouldn't introduce any changes in behaviour.